"""Test deprecation of RPC calls."""
from test_framework.test_framework import BitcoinTestFramework
# from test_framework.util import assert_raises_rpc_error


class DeprecatedRpcTest(BitcoinTestFramework):
    def set_test_params(self):
        self.num_nodes = 2
        self.setup_clean_chain = True
        self.extra_args = [[], []]

    def run_test(self):
        # This test should be used to verify correct behaviour of deprecated
        # RPC methods with and without the -deprecatedrpc flags. For example:
        #
        # In set_test_params:
        # self.extra_args = [[], ["-deprecatedrpc=generate"]]
        #
        # In run_test:
        # self.log.info("Test generate RPC")
        # assert_raises_rpc_error(-32, 'The wallet generate rpc method is deprecated', self.nodes[0].rpc.generate, 1)
        # self.nodes[1].generate(1)
        self.log.info("No tested deprecated RPC methods")


if __name__ == '__main__':
    DeprecatedRpcTest().main()

"""Test deprecation of RPC calls."""
from test_framework.test_framework import BitcoinTestFramework


class DeprecatedRpcTest(BitcoinTestFramework):
    def set_test_params(self):
        self.num_nodes = 2
        self.setup_clean_chain = True
        self.extra_args = [[], ["-deprecatedrpc=banscore"]]

    def run_test(self):
        # This test should be used to verify correct behaviour of deprecated
        # RPC methods with and without the -deprecatedrpc flags. For example:
        #
        # In set_test_params:
        # self.extra_args = [[], ["-deprecatedrpc=generate"]]
        #
        # In run_test:
        # self.log.info("Test generate RPC")
        # assert_raises_rpc_error(-32, 'The wallet generate rpc method is deprecated', self.nodes[0].rpc.generate, 1)
        # self.nodes[1].generate(1)

        self.log.info("Test deprecated banscore")
        assert 'banscore' not in self.nodes[0].getpeerinfo()[0]
        assert 'banscore' in self.nodes[1].getpeerinfo()[0]


if __name__ == '__main__':
    DeprecatedRpcTest().main()

Add a test for the banscore deprecation
Add a test for the banscore deprecation

Summary: This is what the `rpc_deprecated.py` test is for.

Test Plan:
  ./test/functional/test_runner.py rpc_deprecated

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D8915

  """Test deprecation of RPC calls."""
  from test_framework.test_framework import BitcoinTestFramework
- # from test_framework.util import assert_raises_rpc_error
  
  
  class DeprecatedRpcTest(BitcoinTestFramework):
      def set_test_params(self):
          self.num_nodes = 2
          self.setup_clean_chain = True
-         self.extra_args = [[], []]
+         self.extra_args = [[], ["-deprecatedrpc=banscore"]]
  
      def run_test(self):
          # This test should be used to verify correct behaviour of deprecated
          # RPC methods with and without the -deprecatedrpc flags. For example:
          #
          # In set_test_params:
          # self.extra_args = [[], ["-deprecatedrpc=generate"]]
          #
          # In run_test:
          # self.log.info("Test generate RPC")
          # assert_raises_rpc_error(-32, 'The wallet generate rpc method is deprecated', self.nodes[0].rpc.generate, 1)
          # self.nodes[1].generate(1)
+ 
-         self.log.info("No tested deprecated RPC methods")
+         self.log.info("Test deprecated banscore")
+         assert 'banscore' not in self.nodes[0].getpeerinfo()[0]
+         assert 'banscore' in self.nodes[1].getpeerinfo()[0]
  
  
  if __name__ == '__main__':
      DeprecatedRpcTest().main()
  
Add a test for the banscore deprecation
## Code Before:
"""Test deprecation of RPC calls."""
from test_framework.test_framework import BitcoinTestFramework
# from test_framework.util import assert_raises_rpc_error


class DeprecatedRpcTest(BitcoinTestFramework):
    def set_test_params(self):
        self.num_nodes = 2
        self.setup_clean_chain = True
        self.extra_args = [[], []]

    def run_test(self):
        # This test should be used to verify correct behaviour of deprecated
        # RPC methods with and without the -deprecatedrpc flags. For example:
        #
        # In set_test_params:
        # self.extra_args = [[], ["-deprecatedrpc=generate"]]
        #
        # In run_test:
        # self.log.info("Test generate RPC")
        # assert_raises_rpc_error(-32, 'The wallet generate rpc method is deprecated', self.nodes[0].rpc.generate, 1)
        # self.nodes[1].generate(1)
        self.log.info("No tested deprecated RPC methods")


if __name__ == '__main__':
    DeprecatedRpcTest().main()

## Instruction:
Add a test for the banscore deprecation
## Code After:
"""Test deprecation of RPC calls."""
from test_framework.test_framework import BitcoinTestFramework


class DeprecatedRpcTest(BitcoinTestFramework):
    def set_test_params(self):
        self.num_nodes = 2
        self.setup_clean_chain = True
        self.extra_args = [[], ["-deprecatedrpc=banscore"]]

    def run_test(self):
        # This test should be used to verify correct behaviour of deprecated
        # RPC methods with and without the -deprecatedrpc flags. For example:
        #
        # In set_test_params:
        # self.extra_args = [[], ["-deprecatedrpc=generate"]]
        #
        # In run_test:
        # self.log.info("Test generate RPC")
        # assert_raises_rpc_error(-32, 'The wallet generate rpc method is deprecated', self.nodes[0].rpc.generate, 1)
        # self.nodes[1].generate(1)

        self.log.info("Test deprecated banscore")
        assert 'banscore' not in self.nodes[0].getpeerinfo()[0]
        assert 'banscore' in self.nodes[1].getpeerinfo()[0]


if __name__ == '__main__':
    DeprecatedRpcTest().main()
