from django.conf.urls import patterns
from djproxy.views import HttpProxy


def generate_routes(config):
    routes = []
    for service_name, proxy_config in config.items():
        ProxyClass = type(
            'ProxyClass',
            (HttpProxy, ),
            {'base_url': proxy_config['base_url']}
        )
        routes.append((
            r'^%s' % proxy_config['prefix'],
            ProxyClass.as_view()
        ))
    return routes

import re

from django.conf.urls import patterns, url

from djproxy.views import HttpProxy


def generate_routes(config):
    routes = ()
    for service_name, proxy_config in config.items():
        base_url = proxy_config['base_url']
        prefix = proxy_config['prefix']

        ProxyClass = type('ProxyClass', (HttpProxy,), {'base_url': base_url})

        routes += url(r'^%s' % prefix.lstrip('/'), ProxyClass.as_view()),

    return patterns('', *routes)

Return a `patterns` rather than a list of tuples
Return a `patterns` rather than a list of tuples

+ import re
+ 
- from django.conf.urls import patterns
+ from django.conf.urls import patterns, url
+ 
  from djproxy.views import HttpProxy
  
  
  def generate_routes(config):
-     routes = []
+     routes = ()
      for service_name, proxy_config in config.items():
-         ProxyClass = type(
-             'ProxyClass',
-             (HttpProxy, ),
-             {'base_url': proxy_config['base_url']}
+         base_url = proxy_config['base_url']
-         )
-         routes.append((
-             r'^%s' % proxy_config['prefix'],
+         prefix = proxy_config['prefix']
-             ProxyClass.as_view()
-         ))
-     return routes
  
+         ProxyClass = type('ProxyClass', (HttpProxy,), {'base_url': base_url})
+ 
+         routes += url(r'^%s' % prefix.lstrip('/'), ProxyClass.as_view()),
+ 
+     return patterns('', *routes)
+ 
Return a `patterns` rather than a list of tuples
## Code Before:
from django.conf.urls import patterns
from djproxy.views import HttpProxy


def generate_routes(config):
    routes = []
    for service_name, proxy_config in config.items():
        ProxyClass = type(
            'ProxyClass',
            (HttpProxy, ),
            {'base_url': proxy_config['base_url']}
        )
        routes.append((
            r'^%s' % proxy_config['prefix'],
            ProxyClass.as_view()
        ))
    return routes

## Instruction:
Return a `patterns` rather than a list of tuples
## Code After:
import re

from django.conf.urls import patterns, url

from djproxy.views import HttpProxy


def generate_routes(config):
    routes = ()
    for service_name, proxy_config in config.items():
        base_url = proxy_config['base_url']
        prefix = proxy_config['prefix']

        ProxyClass = type('ProxyClass', (HttpProxy,), {'base_url': base_url})

        routes += url(r'^%s' % prefix.lstrip('/'), ProxyClass.as_view()),

    return patterns('', *routes)
