
from snaps.openstack.utils import neutron_utils, nova_utils


def get_ext_net_name(os_creds):
    """
    Returns the first external network name
    :param: os_creds: an instance of snaps OSCreds object
    :return:
    """
    neutron = neutron_utils.neutron_client(os_creds)
    ext_nets = neutron_utils.get_external_networks(neutron)
    return ext_nets[0].name if ext_nets else ""


def get_active_compute_cnt(os_creds):
    """
    Returns the number of active compute servers
    :param: os_creds: an instance of snaps OSCreds object
    :return: the number of active compute servers
    """
    nova = nova_utils.nova_client(os_creds)
    computes = nova_utils.get_availability_zone_hosts(nova, zone_name='nova')
    return len(computes)


from functest.utils.constants import CONST

from snaps.openstack.utils import neutron_utils, nova_utils


def get_ext_net_name(os_creds):
    """
    Returns the configured external network name or
    the first retrieved external network name
    :param: os_creds: an instance of snaps OSCreds object
    :return:
    """
    neutron = neutron_utils.neutron_client(os_creds)
    ext_nets = neutron_utils.get_external_networks(neutron)
    if (hasattr(CONST, 'EXTERNAL_NETWORK')):
        extnet_config = CONST.__getattribute__('EXTERNAL_NETWORK')
        for ext_net in ext_nets:
            if ext_net.name == extnet_config:
                return extnet_config
    return ext_nets[0].name if ext_nets else ""


def get_active_compute_cnt(os_creds):
    """
    Returns the number of active compute servers
    :param: os_creds: an instance of snaps OSCreds object
    :return: the number of active compute servers
    """
    nova = nova_utils.nova_client(os_creds)
    computes = nova_utils.get_availability_zone_hosts(nova, zone_name='nova')
    return len(computes)

Support to specify the valid external network name
Support to specify the valid external network name

In some deployments, the retrieved external network by the
def get_external_networks in Snaps checked by "router:external"
is not available. So it is necessary to specify the available
external network as an env by user.

Change-Id: I333e91dd106ed307541a9a197280199fde86bd30
Signed-off-by: Linda Wang <81613bebe84fa394bbc7c5cc1c21989c9bff2c52@huawei.com>

+ 
+ from functest.utils.constants import CONST
  
  from snaps.openstack.utils import neutron_utils, nova_utils
  
  
  def get_ext_net_name(os_creds):
      """
-     Returns the first external network name
+     Returns the configured external network name or
+     the first retrieved external network name
      :param: os_creds: an instance of snaps OSCreds object
      :return:
      """
      neutron = neutron_utils.neutron_client(os_creds)
      ext_nets = neutron_utils.get_external_networks(neutron)
+     if (hasattr(CONST, 'EXTERNAL_NETWORK')):
+         extnet_config = CONST.__getattribute__('EXTERNAL_NETWORK')
+         for ext_net in ext_nets:
+             if ext_net.name == extnet_config:
+                 return extnet_config
      return ext_nets[0].name if ext_nets else ""
  
  
  def get_active_compute_cnt(os_creds):
      """
      Returns the number of active compute servers
      :param: os_creds: an instance of snaps OSCreds object
      :return: the number of active compute servers
      """
      nova = nova_utils.nova_client(os_creds)
      computes = nova_utils.get_availability_zone_hosts(nova, zone_name='nova')
      return len(computes)
  
Support to specify the valid external network name
## Code Before:

from snaps.openstack.utils import neutron_utils, nova_utils


def get_ext_net_name(os_creds):
    """
    Returns the first external network name
    :param: os_creds: an instance of snaps OSCreds object
    :return:
    """
    neutron = neutron_utils.neutron_client(os_creds)
    ext_nets = neutron_utils.get_external_networks(neutron)
    return ext_nets[0].name if ext_nets else ""


def get_active_compute_cnt(os_creds):
    """
    Returns the number of active compute servers
    :param: os_creds: an instance of snaps OSCreds object
    :return: the number of active compute servers
    """
    nova = nova_utils.nova_client(os_creds)
    computes = nova_utils.get_availability_zone_hosts(nova, zone_name='nova')
    return len(computes)

## Instruction:
Support to specify the valid external network name
## Code After:

from functest.utils.constants import CONST

from snaps.openstack.utils import neutron_utils, nova_utils


def get_ext_net_name(os_creds):
    """
    Returns the configured external network name or
    the first retrieved external network name
    :param: os_creds: an instance of snaps OSCreds object
    :return:
    """
    neutron = neutron_utils.neutron_client(os_creds)
    ext_nets = neutron_utils.get_external_networks(neutron)
    if (hasattr(CONST, 'EXTERNAL_NETWORK')):
        extnet_config = CONST.__getattribute__('EXTERNAL_NETWORK')
        for ext_net in ext_nets:
            if ext_net.name == extnet_config:
                return extnet_config
    return ext_nets[0].name if ext_nets else ""


def get_active_compute_cnt(os_creds):
    """
    Returns the number of active compute servers
    :param: os_creds: an instance of snaps OSCreds object
    :return: the number of active compute servers
    """
    nova = nova_utils.nova_client(os_creds)
    computes = nova_utils.get_availability_zone_hosts(nova, zone_name='nova')
    return len(computes)
