
from storlets.gateway.common.stob import StorletRequest


class StorletGatewayBase(object):

    request_class = StorletRequest

    def __init__(self, conf, logger, scope):
        self.logger = logger
        self.conf = conf
        self.scope = scope

    @classmethod
    def validate_storlet_registration(cls, params, obj):
        raise NotImplementedError("Not implemented: "
                                  "validate_storlet_registration")

    @classmethod
    def validate_dependency_registration(cls, params, obj):
        raise NotImplementedError("Not implemented: "
                                  "validate_dependency_registration")

    def invocation_flow(self, sreq):
        raise NotImplementedError("Not implemented: invocation_flow")


from storlets.gateway.common.stob import StorletRequest


class StorletGatewayBase(object):

    request_class = StorletRequest

    def __init__(self, conf, logger, scope):
        self.logger = logger
        self.conf = conf
        self.scope = scope

    @classmethod
    def validate_storlet_registration(cls, params, obj):
        raise NotImplementedError("Not implemented: "
                                  "validate_storlet_registration")

    @classmethod
    def validate_dependency_registration(cls, params, obj):
        raise NotImplementedError("Not implemented: "
                                  "validate_dependency_registration")

    def invocation_flow(self, sreq, extra_sources=None):
        raise NotImplementedError("Not implemented: invocation_flow")

Use consistent arguments for invocation_flow method
Use consistent arguments for invocation_flow method

Trivial-Fix
Change-Id: I6481147a722b2f366300f2ac7952ebd94f1a2ada

  
  from storlets.gateway.common.stob import StorletRequest
  
  
  class StorletGatewayBase(object):
  
      request_class = StorletRequest
  
      def __init__(self, conf, logger, scope):
          self.logger = logger
          self.conf = conf
          self.scope = scope
  
      @classmethod
      def validate_storlet_registration(cls, params, obj):
          raise NotImplementedError("Not implemented: "
                                    "validate_storlet_registration")
  
      @classmethod
      def validate_dependency_registration(cls, params, obj):
          raise NotImplementedError("Not implemented: "
                                    "validate_dependency_registration")
  
-     def invocation_flow(self, sreq):
+     def invocation_flow(self, sreq, extra_sources=None):
          raise NotImplementedError("Not implemented: invocation_flow")
  
Use consistent arguments for invocation_flow method
## Code Before:

from storlets.gateway.common.stob import StorletRequest


class StorletGatewayBase(object):

    request_class = StorletRequest

    def __init__(self, conf, logger, scope):
        self.logger = logger
        self.conf = conf
        self.scope = scope

    @classmethod
    def validate_storlet_registration(cls, params, obj):
        raise NotImplementedError("Not implemented: "
                                  "validate_storlet_registration")

    @classmethod
    def validate_dependency_registration(cls, params, obj):
        raise NotImplementedError("Not implemented: "
                                  "validate_dependency_registration")

    def invocation_flow(self, sreq):
        raise NotImplementedError("Not implemented: invocation_flow")

## Instruction:
Use consistent arguments for invocation_flow method
## Code After:

from storlets.gateway.common.stob import StorletRequest


class StorletGatewayBase(object):

    request_class = StorletRequest

    def __init__(self, conf, logger, scope):
        self.logger = logger
        self.conf = conf
        self.scope = scope

    @classmethod
    def validate_storlet_registration(cls, params, obj):
        raise NotImplementedError("Not implemented: "
                                  "validate_storlet_registration")

    @classmethod
    def validate_dependency_registration(cls, params, obj):
        raise NotImplementedError("Not implemented: "
                                  "validate_dependency_registration")

    def invocation_flow(self, sreq, extra_sources=None):
        raise NotImplementedError("Not implemented: invocation_flow")
