
import itertools


def update_pagination(entities, request_size, page_size, marker,
                      sort_dir, sort_key, reversed_order):
    has_prev_data = False
    has_more_data = False

    entities = list(itertools.islice(entities, request_size))
    # first and middle page condition
    if len(entities) > page_size:
        entities.pop(-1)
        has_more_data = True
        # middle page condition
        if marker is not None:
            has_prev_data = True
    # first page condition when reached via prev back
    elif reversed_order and marker is not None:
        has_more_data = True
    # last page condition
    elif marker is not None:
        has_prev_data = True

    # restore the original ordering here
    if reversed_order:
        entities = sorted(entities, key=lambda entity:
                          (getattr(entity, sort_key)),
                          reverse=(sort_dir == sort_dir))

    return entities, has_more_data, has_prev_data


import itertools


def update_pagination(entities, request_size, page_size, marker,
                      sort_dir, sort_key, reversed_order):
    has_prev_data = False
    has_more_data = False

    entities = list(itertools.islice(entities, request_size))
    # first and middle page condition
    if len(entities) > page_size:
        entities.pop(-1)
        has_more_data = True
        # middle page condition
        if marker is not None:
            has_prev_data = True
    # first page condition when reached via prev back
    elif reversed_order and marker is not None:
        has_more_data = True
    # last page condition
    elif marker is not None:
        has_prev_data = True

    # restore the original ordering here
    if reversed_order:
        entities.reverse()

    return entities, has_more_data, has_prev_data

Use entities.reverse() rather sorted(.., reverse=True)
Use entities.reverse() rather sorted(.., reverse=True)

Change-Id: I33ee5b078e3d27a45bd159be0f0b241c20792f92

  
  import itertools
  
  
  def update_pagination(entities, request_size, page_size, marker,
                        sort_dir, sort_key, reversed_order):
      has_prev_data = False
      has_more_data = False
  
      entities = list(itertools.islice(entities, request_size))
      # first and middle page condition
      if len(entities) > page_size:
          entities.pop(-1)
          has_more_data = True
          # middle page condition
          if marker is not None:
              has_prev_data = True
      # first page condition when reached via prev back
      elif reversed_order and marker is not None:
          has_more_data = True
      # last page condition
      elif marker is not None:
          has_prev_data = True
  
      # restore the original ordering here
      if reversed_order:
+         entities.reverse()
-         entities = sorted(entities, key=lambda entity:
-                           (getattr(entity, sort_key)),
-                           reverse=(sort_dir == sort_dir))
  
      return entities, has_more_data, has_prev_data
  
Use entities.reverse() rather sorted(.., reverse=True)
## Code Before:

import itertools


def update_pagination(entities, request_size, page_size, marker,
                      sort_dir, sort_key, reversed_order):
    has_prev_data = False
    has_more_data = False

    entities = list(itertools.islice(entities, request_size))
    # first and middle page condition
    if len(entities) > page_size:
        entities.pop(-1)
        has_more_data = True
        # middle page condition
        if marker is not None:
            has_prev_data = True
    # first page condition when reached via prev back
    elif reversed_order and marker is not None:
        has_more_data = True
    # last page condition
    elif marker is not None:
        has_prev_data = True

    # restore the original ordering here
    if reversed_order:
        entities = sorted(entities, key=lambda entity:
                          (getattr(entity, sort_key)),
                          reverse=(sort_dir == sort_dir))

    return entities, has_more_data, has_prev_data

## Instruction:
Use entities.reverse() rather sorted(.., reverse=True)
## Code After:

import itertools


def update_pagination(entities, request_size, page_size, marker,
                      sort_dir, sort_key, reversed_order):
    has_prev_data = False
    has_more_data = False

    entities = list(itertools.islice(entities, request_size))
    # first and middle page condition
    if len(entities) > page_size:
        entities.pop(-1)
        has_more_data = True
        # middle page condition
        if marker is not None:
            has_prev_data = True
    # first page condition when reached via prev back
    elif reversed_order and marker is not None:
        has_more_data = True
    # last page condition
    elif marker is not None:
        has_prev_data = True

    # restore the original ordering here
    if reversed_order:
        entities.reverse()

    return entities, has_more_data, has_prev_data
