
from oslo_policy import policy

from neutron.conf.policies import base


rules = [
    policy.DocumentedRuleDefault(
        'get_network_ip_availability',
        base.RULE_ADMIN_ONLY,
        'Get network IP availability',
        [
            {
                'method': 'GET',
                'path': '/network-ip-availabilities',
            },
            {
                'method': 'GET',
                'path': '/network-ip-availabilities/{network_id}',
            },
        ]
    ),
]


def list_rules():
    return rules


from oslo_log import versionutils
from oslo_policy import policy

from neutron.conf.policies import base

DEPRECATED_REASON = """
The network IP availability API now support system scope and default roles.
"""


rules = [
    policy.DocumentedRuleDefault(
        name='get_network_ip_availability',
        check_str=base.SYSTEM_READER,
        scope_types=['system'],
        description='Get network IP availability',
        operations=[
            {
                'method': 'GET',
                'path': '/network-ip-availabilities',
            },
            {
                'method': 'GET',
                'path': '/network-ip-availabilities/{network_id}',
            },
        ],
        deprecated_rule=policy.DeprecatedRule(
            name='get_network_ip_availability',
            check_str=base.RULE_ADMIN_ONLY),
        deprecated_reason=DEPRECATED_REASON,
        deprecated_since=versionutils.deprecated.WALLABY
    ),
]


def list_rules():
    return rules

Implement secure RBAC for the network IP availability
Implement secure RBAC for the network IP availability

This commit updates the network IP availability policies to understand scope
checking and account for a read-only role. This is part of a broader series of
changes across OpenStack to provide a consistent RBAC experience and improve
security.

Change-Id: Ia965e549ec5d8b23e837b41c304004d8e57785e9

  
+ from oslo_log import versionutils
  from oslo_policy import policy
  
  from neutron.conf.policies import base
  
+ DEPRECATED_REASON = """
+ The network IP availability API now support system scope and default roles.
+ """
+ 
  
  rules = [
      policy.DocumentedRuleDefault(
-         'get_network_ip_availability',
+         name='get_network_ip_availability',
-         base.RULE_ADMIN_ONLY,
+         check_str=base.SYSTEM_READER,
+         scope_types=['system'],
-         'Get network IP availability',
+         description='Get network IP availability',
-         [
+         operations=[
              {
                  'method': 'GET',
                  'path': '/network-ip-availabilities',
              },
              {
                  'method': 'GET',
                  'path': '/network-ip-availabilities/{network_id}',
              },
-         ]
+         ],
+         deprecated_rule=policy.DeprecatedRule(
+             name='get_network_ip_availability',
+             check_str=base.RULE_ADMIN_ONLY),
+         deprecated_reason=DEPRECATED_REASON,
+         deprecated_since=versionutils.deprecated.WALLABY
      ),
  ]
  
  
  def list_rules():
      return rules
  
Implement secure RBAC for the network IP availability
## Code Before:

from oslo_policy import policy

from neutron.conf.policies import base


rules = [
    policy.DocumentedRuleDefault(
        'get_network_ip_availability',
        base.RULE_ADMIN_ONLY,
        'Get network IP availability',
        [
            {
                'method': 'GET',
                'path': '/network-ip-availabilities',
            },
            {
                'method': 'GET',
                'path': '/network-ip-availabilities/{network_id}',
            },
        ]
    ),
]


def list_rules():
    return rules

## Instruction:
Implement secure RBAC for the network IP availability
## Code After:

from oslo_log import versionutils
from oslo_policy import policy

from neutron.conf.policies import base

DEPRECATED_REASON = """
The network IP availability API now support system scope and default roles.
"""


rules = [
    policy.DocumentedRuleDefault(
        name='get_network_ip_availability',
        check_str=base.SYSTEM_READER,
        scope_types=['system'],
        description='Get network IP availability',
        operations=[
            {
                'method': 'GET',
                'path': '/network-ip-availabilities',
            },
            {
                'method': 'GET',
                'path': '/network-ip-availabilities/{network_id}',
            },
        ],
        deprecated_rule=policy.DeprecatedRule(
            name='get_network_ip_availability',
            check_str=base.RULE_ADMIN_ONLY),
        deprecated_reason=DEPRECATED_REASON,
        deprecated_since=versionutils.deprecated.WALLABY
    ),
]


def list_rules():
    return rules
