
from sqlalchemy import Boolean, Column, MetaData, String, Table, text


def upgrade(migrate_engine):
    """Add replication info to clusters table."""
    meta = MetaData()
    meta.bind = migrate_engine

    clusters = Table('clusters', meta, autoload=True)
    replication_status = Column('replication_status', String(length=36),
                                default="not-capable")
    active_backend_id = Column('active_backend_id', String(length=255))
    frozen = Column('frozen', Boolean, nullable=False, default=False,
                    server_default=text('false'))

    clusters.create_column(replication_status)
    clusters.create_column(frozen)
    clusters.create_column(active_backend_id)


from sqlalchemy import Boolean, Column, MetaData, String, Table
from sqlalchemy.sql import expression


def upgrade(migrate_engine):
    """Add replication info to clusters table."""
    meta = MetaData()
    meta.bind = migrate_engine

    clusters = Table('clusters', meta, autoload=True)
    replication_status = Column('replication_status', String(length=36),
                                default="not-capable")
    active_backend_id = Column('active_backend_id', String(length=255))
    frozen = Column('frozen', Boolean, nullable=False, default=False,
                    server_default=expression.false())

    clusters.create_column(replication_status)
    clusters.create_column(frozen)
    clusters.create_column(active_backend_id)

Fix cannot add a column with non-constant default
Fix cannot add a column with non-constant default

With newer versions of sqlite tests are failing
on sqlite3.OperationalError : Cannot add a column with
non-constant default. In SQL queries is boolean without
apostrophes which causes sqlite3 error. This fix is
solving this issue by replacing text('false') to
expression.false() from sqlalchemy.sql which is
working correct.

Change-Id: Ia96255a2a61994a18b21acc235931ad03a8501ea
Closes-Bug: #1773123

  
- from sqlalchemy import Boolean, Column, MetaData, String, Table, text
+ from sqlalchemy import Boolean, Column, MetaData, String, Table
+ from sqlalchemy.sql import expression
  
  
  def upgrade(migrate_engine):
      """Add replication info to clusters table."""
      meta = MetaData()
      meta.bind = migrate_engine
  
      clusters = Table('clusters', meta, autoload=True)
      replication_status = Column('replication_status', String(length=36),
                                  default="not-capable")
      active_backend_id = Column('active_backend_id', String(length=255))
      frozen = Column('frozen', Boolean, nullable=False, default=False,
-                     server_default=text('false'))
+                     server_default=expression.false())
  
      clusters.create_column(replication_status)
      clusters.create_column(frozen)
      clusters.create_column(active_backend_id)
  
Fix cannot add a column with non-constant default
## Code Before:

from sqlalchemy import Boolean, Column, MetaData, String, Table, text


def upgrade(migrate_engine):
    """Add replication info to clusters table."""
    meta = MetaData()
    meta.bind = migrate_engine

    clusters = Table('clusters', meta, autoload=True)
    replication_status = Column('replication_status', String(length=36),
                                default="not-capable")
    active_backend_id = Column('active_backend_id', String(length=255))
    frozen = Column('frozen', Boolean, nullable=False, default=False,
                    server_default=text('false'))

    clusters.create_column(replication_status)
    clusters.create_column(frozen)
    clusters.create_column(active_backend_id)

## Instruction:
Fix cannot add a column with non-constant default
## Code After:

from sqlalchemy import Boolean, Column, MetaData, String, Table
from sqlalchemy.sql import expression


def upgrade(migrate_engine):
    """Add replication info to clusters table."""
    meta = MetaData()
    meta.bind = migrate_engine

    clusters = Table('clusters', meta, autoload=True)
    replication_status = Column('replication_status', String(length=36),
                                default="not-capable")
    active_backend_id = Column('active_backend_id', String(length=255))
    frozen = Column('frozen', Boolean, nullable=False, default=False,
                    server_default=expression.false())

    clusters.create_column(replication_status)
    clusters.create_column(frozen)
    clusters.create_column(active_backend_id)
