
from neutron.objects import l3agent
from neutron.tests.unit.objects import test_base
from neutron.tests.unit import testlib_api


class RouterL3AgentBindingIfaceObjTestCase(test_base.BaseObjectIfaceTestCase):

    _test_class = l3agent.RouterL3AgentBinding


class RouterL3AgentBindingDbObjTestCase(test_base.BaseDbObjectTestCase,
                                        testlib_api.SqlTestCase):

    _test_class = l3agent.RouterL3AgentBinding

    def setUp(self):
        super(RouterL3AgentBindingDbObjTestCase, self).setUp()
        self._create_test_router()

        def getter():
            self._create_test_agent()
            return self._agent['id']

        self.update_obj_fields(
            {'router_id': self._router.id,
             'l3_agent_id': getter})


from neutron.objects import l3agent
from neutron.tests.unit.objects import test_base
from neutron.tests.unit import testlib_api


class RouterL3AgentBindingIfaceObjTestCase(test_base.BaseObjectIfaceTestCase):

    _test_class = l3agent.RouterL3AgentBinding


class RouterL3AgentBindingDbObjTestCase(test_base.BaseDbObjectTestCase,
                                        testlib_api.SqlTestCase):

    _test_class = l3agent.RouterL3AgentBinding

    def setUp(self):
        super(RouterL3AgentBindingDbObjTestCase, self).setUp()
        self._create_test_router()

        def getter():
            self._create_test_agent()
            return self._agent['id']

        index = iter(range(1, len(self.objs) + 1))
        self.update_obj_fields(
            {'router_id': self._router.id,
             'binding_index': lambda: next(index),
             'l3_agent_id': getter})

Use unique binding_index for RouterL3AgentBinding
Use unique binding_index for RouterL3AgentBinding

This is because (router_id, binding_index) tuple is expected to be
unique, as per db model.

Closes-Bug: #1674434
Change-Id: I64fcee88f2ac942e6fa173644fbfb7655ea6041b

  
  from neutron.objects import l3agent
  from neutron.tests.unit.objects import test_base
  from neutron.tests.unit import testlib_api
  
  
  class RouterL3AgentBindingIfaceObjTestCase(test_base.BaseObjectIfaceTestCase):
  
      _test_class = l3agent.RouterL3AgentBinding
  
  
  class RouterL3AgentBindingDbObjTestCase(test_base.BaseDbObjectTestCase,
                                          testlib_api.SqlTestCase):
  
      _test_class = l3agent.RouterL3AgentBinding
  
      def setUp(self):
          super(RouterL3AgentBindingDbObjTestCase, self).setUp()
          self._create_test_router()
  
          def getter():
              self._create_test_agent()
              return self._agent['id']
  
+         index = iter(range(1, len(self.objs) + 1))
          self.update_obj_fields(
              {'router_id': self._router.id,
+              'binding_index': lambda: next(index),
               'l3_agent_id': getter})
  
Use unique binding_index for RouterL3AgentBinding
## Code Before:

from neutron.objects import l3agent
from neutron.tests.unit.objects import test_base
from neutron.tests.unit import testlib_api


class RouterL3AgentBindingIfaceObjTestCase(test_base.BaseObjectIfaceTestCase):

    _test_class = l3agent.RouterL3AgentBinding


class RouterL3AgentBindingDbObjTestCase(test_base.BaseDbObjectTestCase,
                                        testlib_api.SqlTestCase):

    _test_class = l3agent.RouterL3AgentBinding

    def setUp(self):
        super(RouterL3AgentBindingDbObjTestCase, self).setUp()
        self._create_test_router()

        def getter():
            self._create_test_agent()
            return self._agent['id']

        self.update_obj_fields(
            {'router_id': self._router.id,
             'l3_agent_id': getter})

## Instruction:
Use unique binding_index for RouterL3AgentBinding
## Code After:

from neutron.objects import l3agent
from neutron.tests.unit.objects import test_base
from neutron.tests.unit import testlib_api


class RouterL3AgentBindingIfaceObjTestCase(test_base.BaseObjectIfaceTestCase):

    _test_class = l3agent.RouterL3AgentBinding


class RouterL3AgentBindingDbObjTestCase(test_base.BaseDbObjectTestCase,
                                        testlib_api.SqlTestCase):

    _test_class = l3agent.RouterL3AgentBinding

    def setUp(self):
        super(RouterL3AgentBindingDbObjTestCase, self).setUp()
        self._create_test_router()

        def getter():
            self._create_test_agent()
            return self._agent['id']

        index = iter(range(1, len(self.objs) + 1))
        self.update_obj_fields(
            {'router_id': self._router.id,
             'binding_index': lambda: next(index),
             'l3_agent_id': getter})
