
from oslo_policy import policy

from nova.policies import base


POLICY_ROOT = 'os_compute_api:os-migrate-server:%s'


migrate_server_policies = [
    policy.DocumentedRuleDefault(
        POLICY_ROOT % 'migrate',
        base.RULE_ADMIN_API,
        "Cold migrate a server to a host",
        [
            {
                'method': 'POST',
                'path': '/servers/{server_id}/action (migrate)'
            }
        ]),
    policy.DocumentedRuleDefault(
        POLICY_ROOT % 'migrate_live',
        base.RULE_ADMIN_API,
        "Live migrate a server to a new host without a reboot",
        [
            {
                'method': 'POST',
                'path': '/servers/{server_id}/action (os-migrateLive)'
            }
        ]),
]


def list_rules():
    return migrate_server_policies


from oslo_policy import policy

from nova.policies import base


POLICY_ROOT = 'os_compute_api:os-migrate-server:%s'


migrate_server_policies = [
    policy.DocumentedRuleDefault(
        name=POLICY_ROOT % 'migrate',
        check_str=base.RULE_ADMIN_API,
        description="Cold migrate a server to a host",
        operations=[
            {
                'method': 'POST',
                'path': '/servers/{server_id}/action (migrate)'
            }
        ],
        scope_types=['system', 'project']),
    policy.DocumentedRuleDefault(
        name=POLICY_ROOT % 'migrate_live',
        check_str=base.RULE_ADMIN_API,
        description="Live migrate a server to a new host without a reboot",
        operations=[
            {
                'method': 'POST',
                'path': '/servers/{server_id}/action (os-migrateLive)'
            }
        ],
        scope_types=['system', 'project']),
]


def list_rules():
    return migrate_server_policies

Introduce scope_types in migrate server
Introduce scope_types in migrate server

oslo.policy introduced the scope_type feature which can
control the access level at system-level and project-level.
 - https://docs.openstack.org/oslo.policy/latest/user/usage.html#setting-scope
 - http://specs.openstack.org/openstack/keystone-specs/specs/keystone/queens/system-scope.html

Appropriate scope_type for nova case:
- https://specs.openstack.org/openstack/nova-specs/specs/ussuri/approved/policy-defaults-refresh.html#scope

This commit introduce scope_type for migrate server API policies
as 'system'.

Also adds the test case with scope_type enabled and verify we
pass and fail the policy check with expected context.

Partial implement blueprint policy-defaults-refresh

Change-Id: Icba4c14f240215fd56f1cdd9814cc81ebf2796be

  
  from oslo_policy import policy
  
  from nova.policies import base
  
  
  POLICY_ROOT = 'os_compute_api:os-migrate-server:%s'
  
  
  migrate_server_policies = [
      policy.DocumentedRuleDefault(
-         POLICY_ROOT % 'migrate',
+         name=POLICY_ROOT % 'migrate',
-         base.RULE_ADMIN_API,
+         check_str=base.RULE_ADMIN_API,
-         "Cold migrate a server to a host",
+         description="Cold migrate a server to a host",
-         [
+         operations=[
              {
                  'method': 'POST',
                  'path': '/servers/{server_id}/action (migrate)'
              }
-         ]),
+         ],
+         scope_types=['system', 'project']),
      policy.DocumentedRuleDefault(
-         POLICY_ROOT % 'migrate_live',
+         name=POLICY_ROOT % 'migrate_live',
-         base.RULE_ADMIN_API,
+         check_str=base.RULE_ADMIN_API,
-         "Live migrate a server to a new host without a reboot",
+         description="Live migrate a server to a new host without a reboot",
-         [
+         operations=[
              {
                  'method': 'POST',
                  'path': '/servers/{server_id}/action (os-migrateLive)'
              }
-         ]),
+         ],
+         scope_types=['system', 'project']),
  ]
  
  
  def list_rules():
      return migrate_server_policies
  
Introduce scope_types in migrate server
## Code Before:

from oslo_policy import policy

from nova.policies import base


POLICY_ROOT = 'os_compute_api:os-migrate-server:%s'


migrate_server_policies = [
    policy.DocumentedRuleDefault(
        POLICY_ROOT % 'migrate',
        base.RULE_ADMIN_API,
        "Cold migrate a server to a host",
        [
            {
                'method': 'POST',
                'path': '/servers/{server_id}/action (migrate)'
            }
        ]),
    policy.DocumentedRuleDefault(
        POLICY_ROOT % 'migrate_live',
        base.RULE_ADMIN_API,
        "Live migrate a server to a new host without a reboot",
        [
            {
                'method': 'POST',
                'path': '/servers/{server_id}/action (os-migrateLive)'
            }
        ]),
]


def list_rules():
    return migrate_server_policies

## Instruction:
Introduce scope_types in migrate server
## Code After:

from oslo_policy import policy

from nova.policies import base


POLICY_ROOT = 'os_compute_api:os-migrate-server:%s'


migrate_server_policies = [
    policy.DocumentedRuleDefault(
        name=POLICY_ROOT % 'migrate',
        check_str=base.RULE_ADMIN_API,
        description="Cold migrate a server to a host",
        operations=[
            {
                'method': 'POST',
                'path': '/servers/{server_id}/action (migrate)'
            }
        ],
        scope_types=['system', 'project']),
    policy.DocumentedRuleDefault(
        name=POLICY_ROOT % 'migrate_live',
        check_str=base.RULE_ADMIN_API,
        description="Live migrate a server to a new host without a reboot",
        operations=[
            {
                'method': 'POST',
                'path': '/servers/{server_id}/action (os-migrateLive)'
            }
        ],
        scope_types=['system', 'project']),
]


def list_rules():
    return migrate_server_policies
