from nose.tools import *
import os
import time
from shellstreaming.inputstream.textfile import TextFile


TEST_FILE = os.path.abspath(os.path.dirname(__file__)) + '/test_textfile_input01.txt'


def test_textfile_usage():
    n_batches = n_records = 0
    stream = TextFile(TEST_FILE, batch_span_ms=20)
    for batch in stream:
        if batch is None:
            time.sleep(0.1)
            continue

        assert_greater_equal(len(batch), 1)
        n_batches += 1
        for record in batch:
            eq_(len(record), 1)
            line = record[0]
            eq_('line ', line[0:5])
            ok_(0 <= int(line[5:]) < 100)  # record order in a batch is not always 'oldest-first'
            n_records += 1
    print('number of batches (%d) >= 1 ?' % (n_batches))
    assert_greater_equal(n_batches, 1)
    eq_(n_records, 100)

from nose.tools import *
import time
from os.path import abspath, dirname, join
from shellstreaming.inputstream.textfile import TextFile


TEST_FILE = join(abspath(dirname(__file__)), 'test_textfile_input01.txt')


def test_textfile_usage():
    n_batches = n_records = 0
    stream = TextFile(TEST_FILE, batch_span_ms=20)
    for batch in stream:
        if batch is None:
            time.sleep(0.1)
            continue

        assert_greater_equal(len(batch), 1)
        n_batches += 1
        for record in batch:
            eq_(len(record), 1)
            line = record[0]
            eq_('line ', line[0:5])
            ok_(0 <= int(line[5:]) < 100)  # record order in a batch is not always 'oldest-first'
            n_records += 1
    print('number of batches (%d) >= 1 ?' % (n_batches))
    assert_greater_equal(n_batches, 1)
    eq_(n_records, 100)

Use os.path.join instead of string concatenation.
Use os.path.join instead of string concatenation.

Use `join` in order to create path intelligently on all operating
systems. See: http://docs.python.org/2/library/os.path.html#os.path.join

  from nose.tools import *
- import os
  import time
+ from os.path import abspath, dirname, join
  from shellstreaming.inputstream.textfile import TextFile
  
  
- TEST_FILE = os.path.abspath(os.path.dirname(__file__)) + '/test_textfile_input01.txt'
+ TEST_FILE = join(abspath(dirname(__file__)), 'test_textfile_input01.txt')
  
  
  def test_textfile_usage():
      n_batches = n_records = 0
      stream = TextFile(TEST_FILE, batch_span_ms=20)
      for batch in stream:
          if batch is None:
              time.sleep(0.1)
              continue
  
          assert_greater_equal(len(batch), 1)
          n_batches += 1
          for record in batch:
              eq_(len(record), 1)
              line = record[0]
              eq_('line ', line[0:5])
              ok_(0 <= int(line[5:]) < 100)  # record order in a batch is not always 'oldest-first'
              n_records += 1
      print('number of batches (%d) >= 1 ?' % (n_batches))
      assert_greater_equal(n_batches, 1)
      eq_(n_records, 100)
  
Use os.path.join instead of string concatenation.
## Code Before:
from nose.tools import *
import os
import time
from shellstreaming.inputstream.textfile import TextFile


TEST_FILE = os.path.abspath(os.path.dirname(__file__)) + '/test_textfile_input01.txt'


def test_textfile_usage():
    n_batches = n_records = 0
    stream = TextFile(TEST_FILE, batch_span_ms=20)
    for batch in stream:
        if batch is None:
            time.sleep(0.1)
            continue

        assert_greater_equal(len(batch), 1)
        n_batches += 1
        for record in batch:
            eq_(len(record), 1)
            line = record[0]
            eq_('line ', line[0:5])
            ok_(0 <= int(line[5:]) < 100)  # record order in a batch is not always 'oldest-first'
            n_records += 1
    print('number of batches (%d) >= 1 ?' % (n_batches))
    assert_greater_equal(n_batches, 1)
    eq_(n_records, 100)

## Instruction:
Use os.path.join instead of string concatenation.
## Code After:
from nose.tools import *
import time
from os.path import abspath, dirname, join
from shellstreaming.inputstream.textfile import TextFile


TEST_FILE = join(abspath(dirname(__file__)), 'test_textfile_input01.txt')


def test_textfile_usage():
    n_batches = n_records = 0
    stream = TextFile(TEST_FILE, batch_span_ms=20)
    for batch in stream:
        if batch is None:
            time.sleep(0.1)
            continue

        assert_greater_equal(len(batch), 1)
        n_batches += 1
        for record in batch:
            eq_(len(record), 1)
            line = record[0]
            eq_('line ', line[0:5])
            ok_(0 <= int(line[5:]) < 100)  # record order in a batch is not always 'oldest-first'
            n_records += 1
    print('number of batches (%d) >= 1 ?' % (n_batches))
    assert_greater_equal(n_batches, 1)
    eq_(n_records, 100)
