
import six

from openstack.tests.functional import base


class TestServiceProvider(base.BaseFunctionalTest):
    def test_list(self):
        providers = list(self.conn.network.service_providers())

        for provide in providers:
            self.assertIsInstance(provide.name, six.string_type)
            self.assertIsInstance(provide.service_type, six.string_types)


from openstack.tests.functional import base


class TestServiceProvider(base.BaseFunctionalTest):
    def test_list(self):
        providers = list(self.conn.network.service_providers())
        names = [o.name for o in providers]
        service_types = [o.service_type for o in providers]
        self.assertIn('ha', names)
        self.assertIn('L3_ROUTER_NAT', service_types)

Fix the network service provider test
Fix the network service provider test

This test was pretty lame before since it just verified that
the result was a string.  Now it verifies that at least one
service provider exists and I think I picked one that should
be aroudn for a while.  The test failure message also prints
the list of providers now so it should be easier to debug.

Partial-bug: #1665495

Change-Id: Ief96558770d81dca81091e235b8d370883b14b94

- 
- import six
  
  from openstack.tests.functional import base
  
  
  class TestServiceProvider(base.BaseFunctionalTest):
      def test_list(self):
          providers = list(self.conn.network.service_providers())
+         names = [o.name for o in providers]
+         service_types = [o.service_type for o in providers]
+         self.assertIn('ha', names)
+         self.assertIn('L3_ROUTER_NAT', service_types)
  
-         for provide in providers:
-             self.assertIsInstance(provide.name, six.string_type)
-             self.assertIsInstance(provide.service_type, six.string_types)
- 
Fix the network service provider test
## Code Before:

import six

from openstack.tests.functional import base


class TestServiceProvider(base.BaseFunctionalTest):
    def test_list(self):
        providers = list(self.conn.network.service_providers())

        for provide in providers:
            self.assertIsInstance(provide.name, six.string_type)
            self.assertIsInstance(provide.service_type, six.string_types)

## Instruction:
Fix the network service provider test
## Code After:

from openstack.tests.functional import base


class TestServiceProvider(base.BaseFunctionalTest):
    def test_list(self):
        providers = list(self.conn.network.service_providers())
        names = [o.name for o in providers]
        service_types = [o.service_type for o in providers]
        self.assertIn('ha', names)
        self.assertIn('L3_ROUTER_NAT', service_types)
