
import imp
from oslo_config import cfg
from watcher.api import config as api_config
from watcher.tests.api import base


class TestRoot(base.FunctionalTest):

    def test_config_enable_webhooks_auth(self):
        acl_public_routes = ['/']
        cfg.CONF.set_override('enable_webhooks_auth', True, 'api')
        imp.reload(api_config)
        self.assertEqual(acl_public_routes,
                         api_config.app['acl_public_routes'])

    def test_config_disable_webhooks_auth(self):
        acl_public_routes = ['/', '/v1/webhooks/.*']
        cfg.CONF.set_override('enable_webhooks_auth', False, 'api')
        imp.reload(api_config)
        self.assertEqual(acl_public_routes,
                         api_config.app['acl_public_routes'])


import importlib
from oslo_config import cfg
from watcher.api import config as api_config
from watcher.tests.api import base


class TestRoot(base.FunctionalTest):

    def test_config_enable_webhooks_auth(self):
        acl_public_routes = ['/']
        cfg.CONF.set_override('enable_webhooks_auth', True, 'api')
        importlib.reload(api_config)
        self.assertEqual(acl_public_routes,
                         api_config.app['acl_public_routes'])

    def test_config_disable_webhooks_auth(self):
        acl_public_routes = ['/', '/v1/webhooks/.*']
        cfg.CONF.set_override('enable_webhooks_auth', False, 'api')
        importlib.reload(api_config)
        self.assertEqual(acl_public_routes,
                         api_config.app['acl_public_routes'])

Use importlib to take place of im module
Use importlib to take place of im module

The imp module is deprecated[1] since version 3.4, use importlib to
instead

1: https://docs.python.org/3/library/imp.html#imp.reload

Change-Id: Ic126bc8e0936e5d7a2c7a910b54b7348026fedcb

  
- import imp
+ import importlib
  from oslo_config import cfg
  from watcher.api import config as api_config
  from watcher.tests.api import base
  
  
  class TestRoot(base.FunctionalTest):
  
      def test_config_enable_webhooks_auth(self):
          acl_public_routes = ['/']
          cfg.CONF.set_override('enable_webhooks_auth', True, 'api')
-         imp.reload(api_config)
+         importlib.reload(api_config)
          self.assertEqual(acl_public_routes,
                           api_config.app['acl_public_routes'])
  
      def test_config_disable_webhooks_auth(self):
          acl_public_routes = ['/', '/v1/webhooks/.*']
          cfg.CONF.set_override('enable_webhooks_auth', False, 'api')
-         imp.reload(api_config)
+         importlib.reload(api_config)
          self.assertEqual(acl_public_routes,
                           api_config.app['acl_public_routes'])
  
Use importlib to take place of im module
## Code Before:

import imp
from oslo_config import cfg
from watcher.api import config as api_config
from watcher.tests.api import base


class TestRoot(base.FunctionalTest):

    def test_config_enable_webhooks_auth(self):
        acl_public_routes = ['/']
        cfg.CONF.set_override('enable_webhooks_auth', True, 'api')
        imp.reload(api_config)
        self.assertEqual(acl_public_routes,
                         api_config.app['acl_public_routes'])

    def test_config_disable_webhooks_auth(self):
        acl_public_routes = ['/', '/v1/webhooks/.*']
        cfg.CONF.set_override('enable_webhooks_auth', False, 'api')
        imp.reload(api_config)
        self.assertEqual(acl_public_routes,
                         api_config.app['acl_public_routes'])

## Instruction:
Use importlib to take place of im module
## Code After:

import importlib
from oslo_config import cfg
from watcher.api import config as api_config
from watcher.tests.api import base


class TestRoot(base.FunctionalTest):

    def test_config_enable_webhooks_auth(self):
        acl_public_routes = ['/']
        cfg.CONF.set_override('enable_webhooks_auth', True, 'api')
        importlib.reload(api_config)
        self.assertEqual(acl_public_routes,
                         api_config.app['acl_public_routes'])

    def test_config_disable_webhooks_auth(self):
        acl_public_routes = ['/', '/v1/webhooks/.*']
        cfg.CONF.set_override('enable_webhooks_auth', False, 'api')
        importlib.reload(api_config)
        self.assertEqual(acl_public_routes,
                         api_config.app['acl_public_routes'])
