Best treatment of old fracture is
Nonunion fracture shaft femur requires open reduction and rigid internal fixation with either intramedullary nail or DC plating and bone grafting.
Manipulation and POP cast application.
Open reduction and internal fixation and bone grafting.
K Wire fixation
External fixation