Simplify SortStarted function signature
@@ -546,7 +546,7 @@ func listBuilds(ctx context.Context, client gcs.Lister, since string, paths ...g
type ColumnReader func(ctx context.Context, log logrus.FieldLogger, tg *configpb.TestGroup, oldCols []InflatedColumn, stop time.Time, receivers chan<- InflatedColumn) error
// SortStarted sorts InflatedColumns by column start time.
-func SortStarted(_ *configpb.TestGroup, cols []InflatedColumn) {
+func SortStarted(cols []InflatedColumn) {
sort.SliceStable(cols, func(i, j int) bool {
return cols[i].Column.Started > cols[j].Column.Started
})
@@ -613,7 +613,7 @@ func InflateDropAppend(ctx context.Context, alog logrus.FieldLogger, client gcs.
cols = append(cols, *col)
floor = when
}
- SortStarted(tg, cols) // Our processing requires descending start time.
+ SortStarted(cols) // Our processing requires descending start time.
oldCols = truncateRunning(cols, floor)
}
var cols []InflatedColumn
@@ -695,7 +695,7 @@ func InflateDropAppend(ctx context.Context, alog logrus.FieldLogger, client gcs.
cols = groupColumns(tg, cols)
}
- SortStarted(tg, cols)
+ SortStarted(cols)
if truncateGrid(cols, byteCeiling) {
cols = groupColumns(tg, cols)
