don't block on stdout during binary build attach
@@ -253,10 +253,6 @@ func (h *binaryInstantiateHandler) handle(r io.Reader) (runtime.Object, error) {
buildPodName := buildapi.GetBuildPodName(build)
opts := &kapi.PodAttachOptions{
Stdin: true,
- // TODO remove Stdout and Stderr once https://github.com/kubernetes/kubernetes/issues/44448 is
- // fixed
- Stdout: true,
- Stderr: true,
Container: buildstrategy.GitCloneContainer,
}
location, transport, err := pod.AttachLocation(h.r.PodGetter, h.r.ConnectionInfo, h.ctx, buildPodName, opts)
@@ -277,8 +273,6 @@ func (h *binaryInstantiateHandler) handle(r io.Reader) (runtime.Object, error) {
}
streamOptions := remotecommand.StreamOptions{
Stdin: r,
- // TODO remove Stdout and Stderr once https://github.com/kubernetes/kubernetes/issues/44448 is
- // fixed
Stdout: ioutil.Discard,
Stderr: ioutil.Discard,
}
