Make mungegithub read config from a mounted configmap instead of flags.
This includes some of the setup work for making mungegithub capable of reloading it's config without restarting. This change allowed the google-cloud-storage and test-options features to be removed. (They were only providing flag values, not full features).
@@ -217,9 +217,9 @@ func TestConfig(t *testing.T) {
t.Errorf("Err : testgrid job %v not found in SQ config", testgridJob)
}
- sqNonBlockingJobs := strings.Split(sqData.Data["submit-queue.nonblocking-jenkins-jobs"], ",")
+ sqNonBlockingJobs := strings.Split(sqData.Data["nonblocking-jenkins-jobs"], ",")
for _, sqJob := range sqNonBlockingJobs {
- if sqJob == "\"\"" { // ignore empty list of jobs
+ if sqJob == "" { // ignore empty list of jobs
continue
}
found := false
