Add pre-review checklist to PR template
* Add pre-review checklist to PR template
We'd like all PRs to meet the minimum requirements for test, docs, and spec
coverage. Make them explicit in the template.
* clarify requirements
@@ -4,21 +4,26 @@ Fixes #
## Proposed Changes
+<!-- Please categorize your changes:
+- :gift: Add new feature
+- :bug: Fix bug
+- :broom: Update or clean up current behavior
+- :wastebasket: Remove feature or internal logic
+-->
+
-
-
-
-<!--
-If this change has user-visible impact, follow the instructions below.
-Examples include:
+### Pre-review Checklist
-- :gift: Add new feature
-- :bug: Fix bug
-- :broom: Update or clean up current behavior
-- :wastebasket: Remove feature or internal logic
+<!-- If these boxes are not checked, you will be asked to complete these requirements or explain why they do not apply to your PR. -->
-Otherwise delete the rest of this template.
--->
+- [ ] **At least 80% unit test coverage**
+- [ ] **E2E tests** for any new behavior
+- [ ] **Docs PR** for any user-facing impact
+- [ ] **Spec PR** for any new API feature
+- [ ] **Conformance test** for any change to the spec
**Release Note**
@@ -28,16 +33,18 @@ below. Include the string "action required" if additional action is required of
users switching to the new release, for example in case of a breaking change.
Write as if you are speaking to users, not other Knative contributors. If this
-change has no user-visible impact, no release-note is needed.
+change has no user-visible impact, no release note is needed.
-->
```release-note
```
+
**Docs**
<!--
:book: If this change has user-visible impact, link to an issue or PR in
https://github.com/knative/docs.
-->
+
