Change AKS workflow args for manual runs
Also document workflow's DNS setup and tear down.
@@ -7,12 +7,8 @@ on:
- cron: '0 5 * * *'
workflow_dispatch:
inputs:
- aws_id:
- description: "AWS_ACCESS_KEY_ID"
- required: false
- default: ""
- aws_key:
- description: "AWS_SECRET_ACCESS_KEY"
+ aks_domain:
+ description: "AKS_DOMAIN"
required: false
default: ""
azure_credentials:
@@ -46,11 +42,13 @@ jobs:
- name: Setup Ginkgo Test Framework
run: go install github.com/onsi/ginkgo/ginkgo@v1.16.2
+ # The system domain is managed by route53, we need credentials to update
+ # it to the loadbalancer's IP
- name: Configure AWS credentials for Route53
uses: aws-actions/configure-aws-credentials@v1
with:
- aws-access-key-id: ${{ github.event.inputs.aws_id || secrets.AWS_ACCESS_KEY_ID }}
- aws-secret-access-key: ${{ github.event.inputs.aws_key || secrets.AWS_SECRET_ACCESS_KEY }}
+ aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
+ aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: us-east-2
# follow https://github.com/marketplace/actions/azure-login#configure-deployment-credentials
@@ -76,14 +74,16 @@ jobs:
REGISTRY_PASSWORD: ${{ secrets.DOCKERHUB_TOKEN }}
REGEX: Scenario3
AWS_ZONE_ID: ${{ secrets.AWS_ZONE_ID }}
- AKS_DOMAIN: ${{ secrets.AKS_DOMAIN }}
+ AKS_DOMAIN: ${{ github.events.inputs.aks_domain || secrets.AKS_DOMAIN }}
shell: bash
run: |
export KUBECONFIG=$PWD/kubeconfig
make test-acceptance-install
- name: Delete AKS cluster
- if: ${{ always() && !github.event.inputs.keep_cluster }}
+ # We always tear down the cluster, to avoid costs. Except when running
+ # manually and keep_cluster was set to a non-empty string, like "yes"
+ if: ${{ !github.event.inputs.keep_cluster }}
shell: bash
run: |
id="${{ steps.create-cluster.outputs.ID }}"
