extended comment, and added reporting of the ignored error
@@ -96,7 +96,13 @@ func RemoveService(logger logr.Logger, cluster *kubernetes.Cluster, app models.A
return errors.Wrap(err, "create a helm client")
}
- // Ignore errors. The release may not be present (for example due to an aborted deployment)
+ // Ignore errors. The release may not be present. For example due to an aborted
+ // deployment. Note that a multitude of different errors was seen for essentially the same
+ // thing, depending on exact timing of deletion to partial creation. Just ignoring a
+ // specific one is fraught. Report, in case we were to generous and debugging is required.
+ if err != nil {
+ logger.Info("release deletion issue", "error", err)
+ }
_ = client.UninstallReleaseByName(names.ServiceReleaseName(app.Name))
return nil
