Enable dashboard test
This test was never broken. My best guess is that CI was not merging with the
latest `main` as we have recently noticed, so this was an issue that was fixed
by
Closes
@@ -4,6 +4,7 @@ import (
"context"
"fmt"
"os"
+ "strconv"
"strings"
"testing"
"time"
@@ -613,6 +614,7 @@ func TestUpgradeHelm(t *testing.T) {
"--set", "dashboard.image.tag=" + TestHelper.GetVersion(),
"--set", "grafana.image.tag=" + TestHelper.GetVersion(),
"--set", "tap.image.tag=" + TestHelper.GetVersion(),
+ "--wait",
}
// Install Viz Extension Chart
if stdout, stderr, err := TestHelper.HelmInstallPlain(vizChart, "l5d-viz", vizArgs...); err != nil {
@@ -813,10 +815,6 @@ func TestInstallSP(t *testing.T) {
}
}
-// This test fails because no web component is installed during this phase of
-// the extension split. It should be renabled after the issue below is closed.
-// Issue: https://github.com/linkerd/linkerd2/issues/5478
-/*
func TestDashboard(t *testing.T) {
dashboardPort := 52237
dashboardURL := fmt.Sprintf("http://localhost:%d", dashboardPort)
@@ -853,7 +851,6 @@ func TestDashboard(t *testing.T) {
resp, TestHelper.GetVersion())
}
}
-*/
func TestInject(t *testing.T) {
resources, err := testutil.ReadFile("testdata/smoke_test.yaml")
