Clarify error messages for nodes that are not connected
If a node does not have an update channel, it is probably not connected,
clarify the log messages and make sure we dont print that it was updated
successfully (continue, not return)
@@ -308,8 +308,8 @@ func (h *Headscale) notifyChangesToPeers(m *Machine) {
Str("func", "notifyChangesToPeers").
Str("machine", m.Name).
Str("peer", p.Name).
- Msgf("Peer %s does not appear to be polling", p.Name)
- return
+ Msgf("Peer %s does not have an open update client, skipping.", p.Name)
+ continue
}
log.Trace().
Str("func", "notifyChangesToPeers").
@@ -380,11 +380,12 @@ func (h *Headscale) sendRequestOnUpdateChannel(m *tailcfg.Node) error {
Msgf("Notified machine %s", m.Name)
}
} else {
+ err := errors.New("machine does not have an open update channel")
log.Info().
Str("func", "requestUpdate").
Str("machine", m.Name).
- Msgf("Machine %s does not appear to be polling", m.Name)
- return errors.New("machine does not seem to be polling")
+ Msgf("Machine %s does not have an open update channel", m.Name)
+ return err
}
return nil
}
