launch: avoid jumping in success cases
Lets avoid 'continue'-jumps when we parsed an invalid service file.
This disrupts the logical execution path. Lets just bail out on fatal
errors, but continue as normal in all other cases.
@@ -1063,13 +1063,9 @@ static int manager_load_service_dir(Manager *manager, const char *dirpath, NSSCa
r = manager_load_service_file(manager, path, nss_cache);
free(path);
- if (r) {
- if (r == MANAGER_E_INVALID_SERVICE_FILE)
- continue;
-
+ if (r && r != MANAGER_E_INVALID_SERVICE_FILE)
return error_trace(r);
}
- }
if (errno > 0)
return error_origin(-errno);
