Added by Thomas Beutlich almost 4 years ago. Updated over 3 years ago.
I revisited the commits bound to #1043, esp. r3630. I do no think that msync is necessary for MemIo. According to http://man7.org/linux/man-pages/man2/msync.2.html msync is only useful for memory mapped files which is not the case in MemIo. I would rather see it in FileIo where memory mapped files are used. Thus my questions in #1043-28 (28) and #1043-29 (29) are still not answered.
#1077: Removed msync() calls from MemIo.
Stumbled upon this because valgrind complains about msync() being called with uninitialized parameters.
After some reading, I agree with Thomas that msync() is not necessary for MemIo. I'd simply remove it. Also, according to this thread, it is not needed before munmap(), at least on POSIX systems.
Robin, I'm not making any changes since you plan to revisit this. If you're ok with my suggestion, you can assign this issue to me and I'll do it.
I'm more than happy to pass this over to you, Andreas. Thank You.
Removed msync() calls from MemIo. Valgrind is happy again. Not planning to make changes to FileIo.
Thanks for considering and fixing this.