fix runtime error in coco evaluator

.idea/workspace.xml

@@ -4,9 +4,11 @@
     <option name="autoReloadType" value="SELECTIVE" />
   </component>
   <component name="ChangeListManager">
-    <list default="true" id="d7806539-b6d6-42e7-bb45-1565f5d54891" name="Changes" comment="Update UI">
+    <list default="true" id="d7806539-b6d6-42e7-bb45-1565f5d54891" name="Changes" comment="fix runtime error in coco evaluator">
       <change beforePath="$PROJECT_DIR$/.idea/workspace.xml" beforeDir="false" afterPath="$PROJECT_DIR$/.idea/workspace.xml" afterDir="false" />
       <change beforePath="$PROJECT_DIR$/demo.py" beforeDir="false" afterPath="$PROJECT_DIR$/demo.py" afterDir="false" />
+      <change beforePath="$PROJECT_DIR$/evaluator.py" beforeDir="false" afterPath="$PROJECT_DIR$/evaluator.py" afterDir="false" />
+      <change beforePath="$PROJECT_DIR$/yolo_dataset.py" beforeDir="false" afterPath="$PROJECT_DIR$/yolo_dataset.py" afterDir="false" />
     </list>
     <option name="SHOW_DIALOG" value="false" />
     <option name="HIGHLIGHT_CONFLICTS" value="true" />
@@ -55,26 +57,26 @@
     <option name="hideEmptyMiddlePackages" value="true" />
     <option name="showLibraryContents" value="true" />
   </component>
-  <component name="PropertiesComponent"><![CDATA[{
-  "keyToString": {
-    "Python.demo.executor": "Debug",
-    "Python.evaluator.executor": "Debug",
-    "Python.extract.executor": "Run",
-    "Python.streamlit.executor": "Debug",
-    "Python.yolo_dataset.executor": "Run",
-    "RunOnceActivity.OpenProjectViewOnStart": "true",
-    "RunOnceActivity.ShowReadmeOnStart": "true",
-    "git-widget-placeholder": "main",
-    "last_opened_file_path": "/Users/famer.me/PycharmProjects/detector/tests",
-    "node.js.detected.package.eslint": "true",
-    "node.js.detected.package.tslint": "true",
-    "node.js.selected.package.eslint": "(autodetect)",
-    "node.js.selected.package.tslint": "(autodetect)",
-    "nodejs_package_manager_path": "npm",
-    "settings.editor.selected.configurable": "settings.qodana",
-    "vue.rearranger.settings.migration": "true"
+  <component name="PropertiesComponent">{
+  &quot;keyToString&quot;: {
+    &quot;Python.demo.executor&quot;: &quot;Debug&quot;,
+    &quot;Python.evaluator.executor&quot;: &quot;Debug&quot;,
+    &quot;Python.extract.executor&quot;: &quot;Run&quot;,
+    &quot;Python.streamlit.executor&quot;: &quot;Debug&quot;,
+    &quot;Python.yolo_dataset.executor&quot;: &quot;Run&quot;,
+    &quot;RunOnceActivity.OpenProjectViewOnStart&quot;: &quot;true&quot;,
+    &quot;RunOnceActivity.ShowReadmeOnStart&quot;: &quot;true&quot;,
+    &quot;git-widget-placeholder&quot;: &quot;main&quot;,
+    &quot;last_opened_file_path&quot;: &quot;/Users/famer.me/PycharmProjects/detector/tests&quot;,
+    &quot;node.js.detected.package.eslint&quot;: &quot;true&quot;,
+    &quot;node.js.detected.package.tslint&quot;: &quot;true&quot;,
+    &quot;node.js.selected.package.eslint&quot;: &quot;(autodetect)&quot;,
+    &quot;node.js.selected.package.tslint&quot;: &quot;(autodetect)&quot;,
+    &quot;nodejs_package_manager_path&quot;: &quot;npm&quot;,
+    &quot;settings.editor.selected.configurable&quot;: &quot;settings.qodana&quot;,
+    &quot;vue.rearranger.settings.migration&quot;: &quot;true&quot;
   }
-}]]></component>
+}</component>
   <component name="RecentsManager">
     <key name="CopyFile.RECENT_KEYS">
       <recent name="$PROJECT_DIR$/tests" />
@@ -236,7 +238,8 @@
       <workItem from="1706151430872" duration="1470000" />
       <workItem from="1706176033980" duration="1344000" />
       <workItem from="1706274709532" duration="27000" />
-      <workItem from="1706445222599" duration="1467000" />
+      <workItem from="1706445222599" duration="1814000" />
+      <workItem from="1706449264770" duration="4885000" />
     </task>
     <task id="LOCAL-00001" summary="init commit">
       <option name="closed" value="true" />
@@ -446,7 +449,15 @@
       <option name="project" value="LOCAL" />
       <updated>1706152276670</updated>
     </task>
-    <option name="localTasksCounter" value="27" />
+    <task id="LOCAL-00027" summary="fix runtime error in coco evaluator">
+      <option name="closed" value="true" />
+      <created>1706446725139</created>
+      <option name="number" value="00027" />
+      <option name="presentableId" value="LOCAL-00027" />
+      <option name="project" value="LOCAL" />
+      <updated>1706446725139</updated>
+    </task>
+    <option name="localTasksCounter" value="28" />
     <servers />
   </component>
   <component name="TypeScriptGeneratedFilesManager">
@@ -490,19 +501,15 @@
     <MESSAGE value="fix confidence" />
     <MESSAGE value="IoU evaluator" />
     <MESSAGE value="Update UI" />
-    <option name="LAST_COMMIT_MESSAGE" value="Update UI" />
+    <MESSAGE value="fix runtime error in coco evaluator" />
+    <option name="LAST_COMMIT_MESSAGE" value="fix runtime error in coco evaluator" />
   </component>
   <component name="XDebuggerManager">
     <breakpoint-manager>
       <breakpoints>
-        <line-breakpoint enabled="true" suspend="THREAD" type="python-line">
-          <url>file:///opt/homebrew/anaconda3/envs/detector/lib/python3.10/site-packages/ultralytics/data/utils.py</url>
-          <line>311</line>
-          <option name="timeStamp" value="9" />
-        </line-breakpoint>
         <line-breakpoint enabled="true" suspend="THREAD" type="python-line">
           <url>file://$PROJECT_DIR$/evaluator.py</url>
-          <line>81</line>
+          <line>77</line>
           <option name="timeStamp" value="17" />
         </line-breakpoint>
       </breakpoints>
@@ -512,7 +519,7 @@
     <SUITE FILE_PATH="coverage/detector$yolo_dataset.coverage" NAME="yolo_dataset Coverage Results" MODIFIED="1705852113469" SOURCE_PROVIDER="com.intellij.coverage.DefaultCoverageFileProvider" RUNNER="coverage.py" COVERAGE_BY_TEST_ENABLED="true" COVERAGE_TRACING_ENABLED="false" WORKING_DIRECTORY="$PROJECT_DIR$" />
     <SUITE FILE_PATH="coverage/detector$evaluator.coverage" NAME="evaluator Coverage Results" MODIFIED="1706107083258" SOURCE_PROVIDER="com.intellij.coverage.DefaultCoverageFileProvider" RUNNER="coverage.py" COVERAGE_BY_TEST_ENABLED="true" COVERAGE_TRACING_ENABLED="false" WORKING_DIRECTORY="$PROJECT_DIR$" />
     <SUITE FILE_PATH="coverage/detector$demo.coverage" NAME="demo Coverage Results" MODIFIED="1706108414052" SOURCE_PROVIDER="com.intellij.coverage.DefaultCoverageFileProvider" RUNNER="coverage.py" COVERAGE_BY_TEST_ENABLED="true" COVERAGE_TRACING_ENABLED="false" WORKING_DIRECTORY="$PROJECT_DIR$" />
-    <SUITE FILE_PATH="coverage/detector$streamlit.coverage" NAME="streamlit Coverage Results" MODIFIED="1706446389552" SOURCE_PROVIDER="com.intellij.coverage.DefaultCoverageFileProvider" RUNNER="coverage.py" COVERAGE_BY_TEST_ENABLED="true" COVERAGE_TRACING_ENABLED="false" WORKING_DIRECTORY="" />
+    <SUITE FILE_PATH="coverage/detector$streamlit.coverage" NAME="streamlit Coverage Results" MODIFIED="1706453912106" SOURCE_PROVIDER="com.intellij.coverage.DefaultCoverageFileProvider" RUNNER="coverage.py" COVERAGE_BY_TEST_ENABLED="true" COVERAGE_TRACING_ENABLED="false" WORKING_DIRECTORY="" />
     <SUITE FILE_PATH="coverage/detector$extract.coverage" NAME="yolo_dataset Coverage Results" MODIFIED="1705764465837" SOURCE_PROVIDER="com.intellij.coverage.DefaultCoverageFileProvider" RUNNER="coverage.py" COVERAGE_BY_TEST_ENABLED="true" COVERAGE_TRACING_ENABLED="false" WORKING_DIRECTORY="$PROJECT_DIR$" />
   </component>
 </project>

demo.py

@@ -49,11 +49,11 @@ def evaluate(model: YoloModel):
     if buffer:
         with st.spinner('Wait for it...'):
             # Slider for changing confidence
-            confidence = st.slider('Confidence Threshold', 0, 100, 30)
+            # confidence = st.slider('Confidence Threshold', 0, 100, 30)
             yolo_dataset = YoloDataset.from_zip_file(ZipFile(buffer))
-            capture_output(evaluator.coco_evaluate)(model=model,
-                                                    dataset=yolo_dataset,
-                                                    confidence_threshold=confidence / 100.0)
+            # capture_output(evaluator.coco_evaluate)(model=model,
+            #                                         dataset=yolo_dataset,
+            #                                         confidence_threshold=confidence / 100.0)
             with evaluator.yolo_evaluator(model, yolo_dataset) as metrics:
                 st.subheader("Metrics:")
                 st.write("Speed: ")

evaluator.py

@@ -17,23 +17,20 @@ def coco_evaluate(model: YoloModel, dataset: YoloDataset, confidence_threshold=0
     evaluator = CocoEvaluator(coco_gt=coco_gt, iou_types=["bbox"])
 
     print("Running evaluation...")
+    coco_anns = []
+
     for image_id, annotations in tqdm(coco_gt.imgToAnns.items()):
         # get the inputs
         image = coco_gt.imgs[image_id]
         results = model.model(source=dataset.load_image(image["file_name"]))
         for result in results:
-            coco_anns = yolo_boxes_to_coco_annotations(image_id, result.boxes,
-                                                       confidence_threshold=confidence_threshold)
-            if len(coco_anns) == 0:
-                continue
-            evaluator.update(coco_anns)
+            coco_anns.extend(yolo_boxes_to_coco_annotations(image_id, result.boxes,
+                                                            confidence_threshold=confidence_threshold))
 
-    if len(evaluator.eval_imgs["bbox"]) == 0:
-        print("No detections!")
-    else:
-        evaluator.synchronize_between_processes()
-        evaluator.accumulate()
-        evaluator.summarize()
+    evaluator.update(coco_anns)
+    evaluator.synchronize_between_processes()
+    evaluator.accumulate()
+    evaluator.summarize()
 
 
 def yolo_evaluator(model: YoloModel, dataset: YoloDataset):
@@ -60,9 +57,8 @@ class Metrics:
 def yolo_boxes_to_coco_annotations(image_id: int, yolo_boxes, confidence_threshold=0.6):
     return [
         {
-            "image_id": image_id,
-            "category_id": box.cls.tolist()[0],
-            "area": box.xywh.tolist()[0][2] * box.xywh.tolist()[0][3],
+            "image_id": int(image_id),
+            "category_id": int(box.cls.tolist()[0]),
             "bbox": box.xywh.tolist()[0],
             "score": box.conf.tolist()[0],
         }

yolo_dataset.py

@@ -87,15 +87,20 @@ class YoloImage:
     def to_coco_annotations(self, image_id: int, ann_id_start: int) -> list[coco_annotation]:
         ann_id = ann_id_start
         annotations: list[coco_annotation] = []
+
         for label in self.labels:
             ann_id = ann_id + 1
             annotations.append({
                 "id": ann_id,
                 "image_id": image_id,
                 "category_id": label['class_id'],
-                "area": label['width'] * label['height'],
-                "bbox": [label['x_center'] - label['width'] / 2, label['y_center'] - label['height'] / 2,
-                         label['width'], label['height']],
+                "area": label['width'] * label['height'] * self.image.width * self.image.height,
+                "bbox": [
+                    (label['x_center'] - label['width'] / 2) * self.image.width,
+                    (label['y_center'] - label['height'] / 2) * self.image.height,
+                    label['width'] * self.image.width,
+                    label['height'] * self.image.height
+                ],
                 "iscrowd": False,
             })
         return annotations