do pickled onions go bad?
It's just a matter of salt, sugar and vinegar levels. If your pickle is sufficient salty/sweet/tart it will never actually go bad in your fridge. Not sure what will happen to onion pickles after a long time in terms of texture but it definitely won't spoil at fridge temps.