These swim shorts look fine.  On the vacation cruise, they look and wear just like a regular pair of shorts.  The advantage is that they really are a swimsuit.  The fabric dries quickly after swimming.  My only problem with them was my own fault:  I kept forgetting to remove the contents from the pockets when I'd jump into the ocean for a swim resulting in a soggy handkerchief, .glasses case and keys.