Excellent pair of underwear. They do not hold any foul odor; great fit-snug but not constrictive. They do NOT roll up!  This was a BIG plus for me since I have large muscular thighs.  I have tried all the other brands of boxer briefs and they do not compare with ExOfficio!  This is my 5th pair and the quality and fit has been consistent.  Buy them; you will NOT regret it!