These work perfectly. Lots of reviews stated that they didn't work as they can still pee through them. As with all swim diapers, thats the case so I wasn't looking for some miracle with these. Much easier than using a disposable swim diaper and trunks over, plus cheaper. Tended to run small so I ordered one size up.  24 month size fit my 18 month old perfectly.