These are ok... they ride up and I didn't feel comfortable in them.  The material is nice and if you like boy shorts and how they fit you will like these.  I didn't like how they rode up while I tried to swim in them.  :)