Good overall.  The size small comes w a large cup.  I bought these for my 12 year old son and he doesnt need a large cup yet :) it was bulky for running so his old cup worked fine for now and inserted in the pocket.