These are great but they fit more like briefs I prefer the bikini briefs style instead.  But these would be a great brief to start with if you're coming from wearing boxers or boxer briefs its a good step forward.  They are a little bit more modest.