Quarterly regression, year-fixed effects I am trying to inspect the heterogeneous effects of a USA-based shock on a panel of countries using quarterly panel data. My variables of interest are the USA-based shock (which has only temporal variation and is mildly serially correlated) and the interaction of this variable with another variable that has cross-sectional and temporal variation too. My question would be whether it makes sense to include year-fixed effects in this regression? 
I mainly worry about something like controlling for a downstream variable (subtracting part of the effect of the US shock with the year-fixed effects).
I guess there's no easy answer. It depends on what you think the data generating process is.
Let $y$ be year, $q$ be the quarter and $c$ be the country.
Then $S_{y,q}$ is the USA shock at year $y$ and quarter $q$, $X_{c,y,q}$ is the observable covariates of country $c$, at year $y$ and quarter $q$ and let $Y_{c,y,q}$ be the variable of interest.
From reading your question, your basic regression looks like this:
$$
Y_{c,y,q} = \alpha_0 + \alpha_1 S_{y,q} + \alpha_2 X_{c,y,q} + \alpha_3 (X_{c,y,q} \times S_{y,q}) + \varepsilon_{c,y,q}.
$$
The underlying assumption is here that:
$$
\mathbb{E}(\varepsilon_{c,y,q}|S_{y,q}) = \mathbb{E}(\varepsilon_{c,y,q}|X_{c,y,q}) = 0
$$

A first thing you might be worried about is that $Y_{c,y,q}$ might be (systematically) different depending on the country in addition to what you observe in $X_{c,y,q}$. In this case, you should probably add country fixed effects.
If you think that $Y_{c,y,q}$ might differ according to the year $y$ in addition to what is explained by $S_{y,q}$ and $X_{c,y,q}$ then you should add year fixed effects.
If you think that $Y_{c,y,q}$ might change with $q$ (e.g. seasonality) in addition to $S_{y,q}$ and $X_{c,y,q}$ then you can add quarter fixed effects.
In principle you coud add country$\times$year fixed effects or country$\times$quarter fixed effects if you are worried about a combination of these problems. If you add year$\times$quarter fixed effects you loose identification for $S_{y,q}$.

Which of these options is best will depend on what exactly you are looking at (i.e. what is $Y_{c,y,q}$) and how you think this changes by factors not included in your regression.
If you decide to add year fe, then the identification of the coefficient on the shock $S_{y,q}$ (and the interaction) only relies on intra-year variation in $S_{y,q}$ and $Y_{c,y,q}$. So if you think there is a lot of yearly variation in $Y_{c,t,q}$ explained by $S_{y,q}$ then you will not be able to capture those when using year fixed effects.
There is also the (subtle) issue of how you define the year. For example, you could define a year from &quot;Januari year $x$&quot; to &quot;December year $x$&quot;. An alternative could be, for example, to define the year from &quot;April year $x$&quot; to &quot;March year $x +1$&quot;. Depending on this choice, your results might vary.