Request for review (S): 8006398: Add regression tests for deprectated GCs
jon.masamitsu at oracle.com
Wed Feb 13 02:40:12 UTC 2013
Changes look good.
You include tests for UseG1GC and UseParallelGC (should
not print warnings) but not UseConcMarkSweepGC nor
UseSerialGC. Why the former but not the latter?
Do you want to test
-XX:+UseConcMarkSweepGC -XX:-CMSIncrementalMode -version
to check that no warning is emitted?
On 2/12/2013 4:56 AM, Bengt Rutisson wrote:
> Hi again,
> Christian has pushed his test library change and it has propagated to
> the hotspot-gc repository. So, this change is ready to be pushed. Just
> need some reviews. Any takers? :)
> On 1/16/13 1:58 PM, Bengt Rutisson wrote:
>> Hi all,
>> Could I have a couple of reviews for this change?
>> Recently we deprecated some GC combinations. Those should now print a
>> warning at startup. Other GC combinations should not print any warnings.
>> With the new process handling support that Christian Törnqvist is
>> adding to the JTREG tests for hotspot it is very easy to write test
>> that start a VM and checks the output.
>> This changes makes use of Christian's testlibrary to verify that
>> warnings are printed as expected.
>> I'm also adding the "gc" keyword to JTREG to make it possible to
>> filter out GC tests. We should probably use this for all test in the
>> the /gc folder, but I think that should be done as a separate change.
>> The webrev above is based on Christian's webrev to add the testlibrary:
More information about the hotspot-gc-dev