The joke is a pun. Weather forecasters predict the weather and the chance of clouds in the sky.  Having clouded thoughts means having distractions or fogginess that prevents focused thinking.
Weather forecasters thinking is sometimes clouded .