neutrinordp: avoid pampassword leakage
The leakage does not occur in the most usual use case of xrdp.
It occurs in NeutrinoRDP proxy mode with PAM authentication enabled.
Reported by
@@ -443,7 +443,14 @@ lxrdp_set_param(struct mod *mod, const char *name, const char *value)
{
rdpSettings *settings;
+ if (g_strcmp(name, "password") == 0 || g_strcmp(name, "pampassword") == 0)
+ {
+ LOG_DEVEL(LOG_LEVEL_DEBUG, "lxrdp_set_param: name [%s] value [******]", name);
+ }
+ else
+ {
LOG_DEVEL(LOG_LEVEL_DEBUG, "lxrdp_set_param: name [%s] value [%s]", name, value);
+ }
settings = mod->inst->settings;
if (g_strcmp(name, "hostname") == 0)
@@ -496,6 +503,10 @@ lxrdp_set_param(struct mod *mod, const char *name, const char *value)
{
settings->desktop_resize = g_text2bool(value);
}
+ else if (g_strcmp(name, "pampassword") == 0)
+ {
+ LOG(LOG_LEVEL_WARNING, "lxrdp_set_param: unknown name [%s] value [******]", name);
+ }
else
{
LOG(LOG_LEVEL_WARNING, "lxrdp_set_param: unknown name [%s] value [%s]", name, value);
