docs: @Override
      public List<ServiceInstance> getAllInstances(String serviceName,
              ServiceInstanceQuery query) throws ServiceException {
  
          ServiceInstanceUtils.validateManagerIsStarted(isStarted);
          ServiceInstanceUtils.validateServiceName(serviceName);
          if (query == null) {
              throw new ServiceException(ErrorCode.SERVICE_DIRECTORY_NULL_ARGUMENT_ERROR,
                       ErrorCode.SERVICE_DIRECTORY_NULL_ARGUMENT_ERROR.getMessageTemplate(),
                      "ServiceInstanceQuery");
          }
  
          List<ModelServiceInstance> modelSvc = getLookupService().getModelInstances(serviceName);
          List<ModelServiceInstance> filteredInstances = ServiceInstanceQueryHelper.filter(query, modelSvc);
          List<ServiceInstance> instances = new ArrayList<ServiceInstance>();
          for (ModelServiceInstance model : filteredInstances) {
              instances.add(ServiceInstanceUtils.toServiceInstance(model));
          }
          return instances;
      }